Appendix Check list for code inspection

Developers can use the following list as a reference.

Item to be checked

OK/NOK

S60 coding conventions have been followed.

 

Localization text files (.loc) have been created and the defined file format is followed.

 

There is layout information of each string in the localization text file.

 

There is context information of each string in the comment field in the localization text file.

 

No text strings appear in the source code. Localizable items are separated from the source code into localization text files.

 

No logical name is used in more than one layout, context, and function.

 

Logical name format is followed in code and in localization text file.

 

Correct layout has been used for each text item.

 

No strings are formed at run time by concatenation.

 

Separate strings are used for singular and plural cases.

 

Abbreviations are represented as logical names in localization lock files, not created by software.

 

StringLoader.h is used for all strings that contain multiple parameters which have to be in changeable order.

 

Unordered parameters are used only if there is one parameter per string.

 

The English text string makes sense.

 

Buffer sizes allow for text expansion.

 

Dynamic buffer sizes are used whenever possible.

 

AVKON components are used whenever possible.

 

BiDi functions are used.

 

TLocale is used to access and update locale-dependant information.

 

Standard S60 date and time formats (=date and time formatters in AVKON) are used.

 

Numbers are formatted using locale settings.

 

No assumptions of available digits. Digits settings of TLocale have been used.

 

If an application relies on the locale settings, it also responds to changes made to locale settings. Use the environment change notifier. (Refer to SDK documentation.)

 

Environment change notifier is used in software modules that are heavily dependant on locale settings.

 

CharConv is used for character conversions.

 

The language statement in MMP files is LANG NN (e.g. LANG 01 04 = UK English and European Spanish included).

 

There is clear understanding of how regionalized features function in language switching.

 

Handling of regionalized features is taken into account (for instance, by flagging them out of the generic code base).